Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/implement new indicator computing #1209

Merged
merged 9 commits into from
Dec 14, 2024

Conversation

alexeh
Copy link
Collaborator

@alexeh alexeh commented Dec 13, 2024

This pull request introduces two new indicator name codes, WW and WC, and integrates them across various modules in the codebase. The changes ensure that these new indicators are properly handled in the DTOs, services, and tests.

Key changes include:

Addition of new indicator codes:

  • Added WW and WC to the INDICATOR_NAME_CODES enum in api/src/modules/indicators/indicator.entity.ts.

DTO updates:

  • Added WW and WC properties to the IndicatorCoefficientsDto class in api/src/modules/indicator-coefficients/dto/indicator-coefficients.dto.ts.

Service updates:

  • Updated QueryPropertyNamesType and QueryPropertyTypes to include WW and WC in api/src/modules/indicator-records/services/impact-calculation.dependencies.ts. [1] [2]
  • Updated QueryPropertyNames and INDICATOR_NAME_CODE_TO_QUERY_MAP to include WW and WC in api/src/modules/indicator-records/services/impact-calculation.dependencies.ts. [1] [2]
  • Added calculation logic for WW and WC in the ImpactCalculator class in api/src/modules/indicator-records/services/impact-calculator.service.ts.

Test updates:

  • Updated integration tests to include WW and WC in api/test/integration/indicator-record/calculations/indicator-records.service.spec.ts.

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
landgriffon-client ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2024 4:43am
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 4:43am
landgriffon-marketing ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2024 4:43am

@alexeh alexeh force-pushed the feat/implement-new-indicator-computing branch from 94a6dc0 to 344b2ac Compare December 13, 2024 05:26
@alexeh alexeh merged commit a542c23 into dev Dec 14, 2024
7 checks passed
@alexeh alexeh deleted the feat/implement-new-indicator-computing branch December 14, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant